Skip to content

Conversation

@SamueleA
Copy link
Contributor

@SamueleA SamueleA commented Nov 11, 2025

Ticket link:

API breaking changes:

  • Yes
  • No

Manual testing required:

  • Yes
  • No

Docs changes required:

  • Yes
  • No

Description

Added an height to content of error state so that it can display properly

@SamueleA SamueleA requested review from a team and 0xsequence-bot as code owners November 11, 2025 17:03
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 11, 2025

Deploying web-sdk-react-example with  Cloudflare Pages  Cloudflare Pages

Latest commit: 38c2c4a
Status: ✅  Deploy successful!
Preview URL: https://e92bc1d8.web-sdk-react-example.pages.dev
Branch Preview URL: https://11112026-add-funds-error-sta.web-sdk-react-example.pages.dev

View logs

@RichardIrala
Copy link
Contributor

Modify

  if (isLoadingTransakLink) {
    return (
      <div className="flex items-center justify-center w-full px-4 pb-4">
        <Spinner />
      </div>
    )
  }

to

  if (isLoadingTransakLink) {
    return (
      <div className="flex items-center justify-center w-full px-4 pb-4 h-[200px]">
        <Spinner />
      </div>
    )
  }

This will also fix the issue where the loading spinner is not displayed.

@SamueleA
Copy link
Contributor Author

Modify

  if (isLoadingTransakLink) {
    return (
      <div className="flex items-center justify-center w-full px-4 pb-4">
        <Spinner />
      </div>
    )
  }

to

  if (isLoadingTransakLink) {
    return (
      <div className="flex items-center justify-center w-full px-4 pb-4 h-[200px]">
        <Spinner />
      </div>
    )
  }

This will also fix the issue where the loading spinner is not displayed.

Updated in 38c2c4a

Copy link
Contributor

@RichardIrala RichardIrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RichardIrala RichardIrala merged commit a0d6eb1 into master Nov 11, 2025
2 checks passed
@RichardIrala RichardIrala deleted the 11112026-add-funds-error-state branch November 11, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants